Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Further optimisations and correctness fixes #77

Closed
raulk opened this issue Apr 24, 2020 · 1 comment
Closed

Further optimisations and correctness fixes #77

raulk opened this issue Apr 24, 2020 · 1 comment
Assignees

Comments

@raulk
Copy link
Member

raulk commented Apr 24, 2020

See follow-up comments on #58. Some highlights:

  • goroutine to monitor the context if a deadline is set, and close the connection if it fires.
  • get rid of readMsgInsecure and writeMsgInsecure abstractions so we can control the buffers.
  • on read, if there are no queued bytes, and the user-provided buffer is large enough, read and decrypt in place. (requires peeking the length of the incoming payload).
  • handshake messages can probably reuse buffers -- their lengths should be predictable.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants