Skip to content
This repository has been archived by the owner on May 26, 2022. It is now read-only.

Filter inbound connections #124

Closed
Stebalien opened this issue Mar 14, 2020 · 1 comment · Fixed by #125
Closed

Filter inbound connections #124

Stebalien opened this issue Mar 14, 2020 · 1 comment · Fixed by #125
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

Transports should apply the "address filters", either directly on all incoming packets or, at least, on the initial handshake packets. Applying them on all incoming packets could be a performance hit at the moment as the filter is very unoptimized.

The transport can get a copy of the filter set by accepting a *github.com/libp2p/go-maddr-filter.Filters in the constructor.

@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Mar 14, 2020
@marten-seemann
Copy link
Collaborator

The easiest solution will probably be to apply the filter to all Long Header packets.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants