This repository has been archived by the owner on May 26, 2022. It is now read-only.
fix: avoid dialing/listening on dns addresses #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
There's a QUIC variable define in mafmt: https://godoc.org/github.com/multiformats/go-multiaddr-fmt#pkg-variables.
Should we use that one?
Stebalien
commented
Apr 3, 2020
| @@ -190,9 +190,12 @@ func (t *transport) Dial(ctx context.Context, raddr ma.Multiaddr, p peer.ID) (tp | |||
| }, nil | |||
| } | |||
|
|
|||
| // Don't use mafmt.QUIC as we don't want to dial DNS addresses. Just /ip{4,6}/udp/quic | |||
There was a problem hiding this comment.
🤦♂️ Sorry for that.
There was a problem hiding this comment.
Yeah, it's confusing. We may want to just go ahead and revert the change in mafmt (we changed it from IP only to IP+DNS). But it does make sense to allow DNS there, just not here.
There was a problem hiding this comment.
LGTM.
Would you mind adding the unit test from transport_test.go in #126 here?
|
I completely forgot about that PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See libp2p/go-libp2p#841