From 83b45b618cb8406a4f42562ebd8c05863a871ac5 Mon Sep 17 00:00:00 2001 From: Matt Joiner Date: Mon, 4 Feb 2019 15:20:35 +1100 Subject: [PATCH 1/2] Fix logging race --- limiter.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/limiter.go b/limiter.go index 2def638c..ce9e2448 100644 --- a/limiter.go +++ b/limiter.go @@ -203,8 +203,10 @@ func (dl *dialLimiter) clearAllPeerDials(p peer.ID) { // channel when finished. Once the response is sent it also releases all tokens // it held during the dial. func (dl *dialLimiter) executeDial(j *dialJob) { + dl.lk.Lock() log.Debugf("[limiter] executing dial (dialfunc); peer: %s; addr: %s; FD consuming: %d; waiting: %d", j.peer, j.addr, dl.fdConsuming, len(dl.waitingOnFd)) + dl.lk.Unlock() defer dl.finishedDial(j) if j.cancelled() { return From 12f5fed21a3aa381a54c5a8734f06e5997f8f24e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Kripalani?= Date: Mon, 4 Feb 2019 17:47:51 +0000 Subject: [PATCH 2/2] remove superfluous log statement. --- limiter.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/limiter.go b/limiter.go index ce9e2448..ef78f0ee 100644 --- a/limiter.go +++ b/limiter.go @@ -203,10 +203,6 @@ func (dl *dialLimiter) clearAllPeerDials(p peer.ID) { // channel when finished. Once the response is sent it also releases all tokens // it held during the dial. func (dl *dialLimiter) executeDial(j *dialJob) { - dl.lk.Lock() - log.Debugf("[limiter] executing dial (dialfunc); peer: %s; addr: %s; FD consuming: %d; waiting: %d", - j.peer, j.addr, dl.fdConsuming, len(dl.waitingOnFd)) - dl.lk.Unlock() defer dl.finishedDial(j) if j.cancelled() { return