Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestProtoDowngrade is flaky #1094

Closed
Stebalien opened this issue May 10, 2021 · 4 comments · Fixed by #1202
Closed

TestProtoDowngrade is flaky #1094

Stebalien opened this issue May 10, 2021 · 4 comments · Fixed by #1202
Labels
kind/test Testing work test_failure

Comments

@Stebalien
Copy link
Member 

basic_host_test.go:517: Application error 0x0

This happens when we try to write to the stream after opening it. It sounds like the connection broke for some reason.

Note: this happened on windows, go 1.15.
@Stebalien
Copy link
Member Author

Thoughts @marten-seemann.

@marten-seemann
Copy link
Contributor

Application error 0x0 is triggered when we (or the peer) class Close on the connection.
How do I trigger this? It might be beneficial to re-run this with quic-go updated to the current version, as we've reworked error reporting recently.

@Stebalien
Copy link
Member Author

It just seems to happen occasionally in CI (especially on windows).

@Stebalien
Copy link
Member Author

Maybe we're closing the connection for some reason? IIRC, we shouldn't be closing duplicate connections, but maybe we are?

@marten-seemann marten-seemann mentioned this issue Sep 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/test Testing work test_failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix flaky BasicHost tests libp2p/go-libp2p
2 participants
@Stebalien @marten-seemann