don't hold the lock when closing #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In libp2p, Close is assumed to be threadsafe and we'd like to interrupt in-progress reads/writes. As a matter of fact, we're lucky this hasn't caused close to hang. If we had tried to close the reader before closing the writer, we would have blocked on a concurrent read call. Part of ipfs/kubo#2823
whyrusleeping
approved these changes
Dec 11, 2017
|
merge when ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In libp2p, Close is assumed to be threadsafe and we'd like to interrupt in-progress reads/writes.
As a matter of fact, we're lucky this hasn't caused close to hang permanently (it still hangs occasionally, just for a bounded amount of time). If we had tried to close the reader before closing the writer, we would have blocked on a concurrent read call.
fixes #8