Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this module obsolete #5

Closed
jbenet opened this issue Apr 23, 2015 · 5 comments
Closed

Make this module obsolete #5

jbenet opened this issue Apr 23, 2015 · 5 comments
Assignees
Labels
help wanted Seeking public contribution on this issue

Comments

@jbenet
Copy link
Contributor

jbenet commented Apr 23, 2015

I would really, really like to make this module (hack) obsolete.

This requires submitting a good patch to upstream Go. see golang/go#9661

@jbenet jbenet added the help wanted Seeking public contribution on this issue label Apr 23, 2015
@jbenet
Copy link
Contributor Author

jbenet commented Dec 12, 2015

want.

@b5
Copy link

b5 commented Mar 14, 2018

2.5 years later, it seems a go CL slated for go 1.11, which might go some ways toward avoiding this: https://gist.github.com/vyzo/62c3fedcc61b958fa401d1340537fd68#file-gistfile1-txt.

According to the release cycle go 1.11 should hit in late August, might be nice to time an ipfs / libp2p update shortly after.

@Kubuxu
Copy link
Member

Kubuxu commented Mar 14, 2018

@b5 My hopes were really high for G1.10 but true, we will have to wait for Go 1.11.

@anacrolix anacrolix self-assigned this Dec 20, 2018
@anacrolix
Copy link
Contributor

The necessary upstream changes have been made, I'll investigate simplifying or removing this package entirely.

@anacrolix
Copy link
Contributor

This repo still has some value as a store for the Control function implementing the socket options for various platforms and Available, in case support isn't present on all platforms. It's possible the remaining behaviour could be merged into the very few repos relying on this repository in the future but I don't think it's clearly worth it at present. We should reopen it if a revisit is required down the track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Development

No branches or pull requests

4 participants