Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move deps to app stage #154

Merged
merged 5 commits into from
Sep 24, 2024
Merged

fix: move deps to app stage #154

merged 5 commits into from
Sep 24, 2024

Conversation

2color
Copy link
Contributor

@2color 2color commented Sep 24, 2024

Description

Moves tini and curl to the app stage of the docker build.

This fixes curl which wasn't working as it relies on shared libs:

ubuntu@libp2p-bootstrap-js:~$ docker exec -it js-libp2p bash
root@libp2p-bootstrap-js:/app# curl
curl: error while loading shared libraries: libcurl.so.4: cannot open shared object file: No such file or directory

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@2color 2color requested a review from achingbrain September 24, 2024 11:39
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achingbrain
Copy link
Member

A multistep build on such a simple container seems like overkill to me, but we can fix that later if we want to.

@2color
Copy link
Contributor Author

2color commented Sep 24, 2024

Simplified the image. Was also a good chance to test building and running it locally

@2color 2color merged commit 1921e35 into main Sep 24, 2024
20 checks passed
@2color 2color deleted the fix-curl branch September 24, 2024 13:56
github-actions bot pushed a commit that referenced this pull request Sep 24, 2024
## [1.5.1](v1.5.0...v1.5.1) (2024-09-24)

### Bug Fixes

* download heapdump instead of writing to disk ([#153](#153)) ([38cf657](38cf657))
* simplify docker image with single stage build ([#154](#154)) ([1921e35](1921e35))
Copy link

🎉 This PR is included in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants