-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move deps to app stage #154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A multistep build on such a simple container seems like overkill to me, but we can fix that later if we want to. |
Simplified the image. Was also a good chance to test building and running it locally |
🎉 This PR is included in version 1.5.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Moves tini and curl to the app stage of the docker build.
This fixes curl which wasn't working as it relies on shared libs:
Change checklist