Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

fix: build #113

Merged
merged 3 commits into from
Apr 13, 2021
Merged

fix: build #113

merged 3 commits into from
Apr 13, 2021

Conversation

vasco-santos
Copy link
Member

No description provided.

@vasco-santos vasco-santos mentioned this pull request Apr 12, 2021
Open
77 tasks
@achingbrain
Copy link
Member

image

@vasco-santos
Copy link
Member Author

thanks good catch, should be good now

@achingbrain
Copy link
Member

I can't add a suggestion but:

- run: npx nyc --reporter=lcov aegir test -t node -- --bail

should change to:

- run: npx aegir test -t node --bail --cov

achingbrain
achingbrain approved these changes Apr 12, 2021
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending aegir coverage command suggestion

@vasco-santos vasco-santos merged commit aeab2bf into master Apr 13, 2021
@vasco-santos vasco-santos deleted the fix/build branch April 13, 2021 07:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vasco-santos @achingbrain