Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Catch error when unmarshaling instead of crashing #112

Closed
mkg20001 opened this issue Nov 27, 2017 · 2 comments
Closed

Catch error when unmarshaling instead of crashing #112

mkg20001 opened this issue Nov 27, 2017 · 2 comments

Comments

@mkg20001
Copy link
Member

The unmarshalPrivateKey function throws an error instead of passing it to the callback which makes the app crash. (That might not be the only function with that bug)

Related libp2p/js-peer-id#72
@mkg20001 mkg20001 mentioned this issue Nov 27, 2017
Merged
@mkg20001
Copy link
Member Author

PR #113

@mkg20001 mkg20001 mentioned this issue Nov 27, 2017
Merged
@daviddias
Copy link
Member

Continue on #113

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daviddias @mkg20001