This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
fix: remove iso-random-stream dependency #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency brings in NodeJS's `Buffer` which then needs to be polyfilled in the browser. @noble/secp256k1 already brings a utility that switch between Node's and the browser's `randomBytes` interfaces.
D4nte
force-pushed
the
remove-iso-random-stream
branch
from
4774a23
to
25493fc
Compare
hugomrdias
approved these changes
Jul 25, 2022
3 tasks
|
This should be fine, I think the only place we need to generate larger chunks of random data is in tests and we can just use |
achingbrain
changed the title
achingbrain
approved these changes
Aug 3, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
## [1.0.2](v1.0.1...v1.0.2) (2022-08-03) ### Bug Fixes * remove iso-random-stream dependency ([#262](#262)) ([c5cb096](c5cb096))
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency brings in NodeJS's
Bufferwhich then needs to be polyfilled in the browser.@noble/*already brings a utility that switch between Node's and the browser'srandomBytesinterfaces.One caveat is that
iso-random-streamenables generation of arrays greater than 65536 in length in the browser.It does not strike to me as a feature needed for libp2p-crypto. Let me know your thoughts.