Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

deps(dev): upgrade aegir to 38.1.2 #302

Merged
merged 7 commits into from
Mar 10, 2023
Merged

Conversation

maschad
Copy link
Member

@maschad maschad commented Feb 9, 2023

No description provided.

@maschad maschad requested review from achingbrain and removed request for wemeetagain February 14, 2023 22:20
@achingbrain achingbrain changed the title chore: upgrade aegir to 38.1.2 deps(dev): upgrade aegir to 38.1.2 Mar 7, 2023
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there, just a few simple changes to make, comments inline.

"benchmark": "^2.1.4",
"protons": "^6.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

protons is used in the generate npm script.

Please update the dep-check command to ignore protons - "dep-check": "aegir dep-check -i protons"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any other packages that dep-check might ignore? May be worthwhile to revisit the functionality of dep-check if this isn't the only exception.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only tests for modules used in code, it doesn't include npm scripts.

I suppose you could get aegir to look at the bin object of every dependency and see if any of the commands are used in the npm scripts of the current project and add the containing module to the ignore list if so but it's a lot of work and may end up with some false positives if two deps export the same command.

Probably not worth the effort IMO.

src/hmac/index.ts Outdated Show resolved Hide resolved
src/keys/ed25519-class.ts Outdated Show resolved Hide resolved
src/keys/ed25519.ts Outdated Show resolved Hide resolved
src/keys/jwk2pem.ts Outdated Show resolved Hide resolved
src/keys/rsa.ts Outdated Show resolved Hide resolved
src/keys/rsa.ts Outdated Show resolved Hide resolved
src/keys/rsa.ts Outdated Show resolved Hide resolved
src/aes/ciphers-browser.ts Outdated Show resolved Hide resolved
src/aes/ciphers-browser.ts Outdated Show resolved Hide resolved
@maschad maschad requested a review from achingbrain March 8, 2023 00:48
src/hmac/index.ts Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 9d60e39 into libp2p:master Mar 10, 2023
github-actions bot pushed a commit that referenced this pull request Mar 10, 2023
## [1.0.13](v1.0.12...v1.0.13) (2023-03-10)

### Trivial Changes

* Update .github/workflows/semantic-pull-request.yml [skip ci] ([b66007c](b66007c))
* Update .github/workflows/semantic-pull-request.yml [skip ci] ([110063c](110063c))
* Update .github/workflows/semantic-pull-request.yml [skip ci] ([c789b0c](c789b0c))

### Dependencies

* **dev:** upgrade aegir to `38.1.2` ([#302](#302)) ([9d60e39](9d60e39))
@github-actions
Copy link

🎉 This PR is included in version 1.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants