-
Notifications
You must be signed in to change notification settings - Fork 52
Conversation
38.1.2
38.1.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there, just a few simple changes to make, comments inline.
"benchmark": "^2.1.4", | ||
"protons": "^6.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protons
is used in the generate
npm script.
Please update the dep-check
command to ignore protons - "dep-check": "aegir dep-check -i protons"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there any other packages that dep-check
might ignore? May be worthwhile to revisit the functionality of dep-check
if this isn't the only exception.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only tests for modules used in code, it doesn't include npm scripts.
I suppose you could get aegir to look at the bin
object of every dependency and see if any of the commands are used in the npm scripts of the current project and add the containing module to the ignore list if so but it's a lot of work and may end up with some false positives if two deps export the same command.
Probably not worth the effort IMO.
## [1.0.13](v1.0.12...v1.0.13) (2023-03-10) ### Trivial Changes * Update .github/workflows/semantic-pull-request.yml [skip ci] ([b66007c](b66007c)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([110063c](110063c)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([c789b0c](c789b0c)) ### Dependencies * **dev:** upgrade aegir to `38.1.2` ([#302](#302)) ([9d60e39](9d60e39))
🎉 This PR is included in version 1.0.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.