This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
chore: update pubsub #108
Merged
chore: update pubsub #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
added
the
status/blocked
vasco-santos
force-pushed
the
chore/update-pubsub
branch
from
3b8279d
to
2e7c1b3
Compare
vasco-santos
force-pushed
the
chore/update-pubsub
branch
2 times, most recently
from
817b05e
to
1e01ed8
Compare
4 tasks
vasco-santos
force-pushed
the
chore/update-pubsub
branch
from
1e01ed8
to
e8002a9
Compare
vasco-santos
force-pushed
the
chore/update-pubsub
branch
from
e8002a9
to
91bf253
Compare
BREAKING CHANGE: subscription event renamed to pubsub:subscription-change
This was referenced Aug 17, 2020
vasco-santos
force-pushed
the
chore/update-pubsub
branch
from
fdf1be2
to
766745b
Compare
vasco-santos
force-pushed
the
chore/update-pubsub
branch
2 times, most recently
from
a95d835
to
db84f14
Compare
vasco-santos
force-pushed
the
chore/update-pubsub
branch
from
db84f14
to
b0d460a
Compare
jacobheun
reviewed
Aug 24, 2020
test/utils/create-peer.js
Outdated
| return peers | ||
| } | ||
|
|
||
| // TODO: use ipfs-utils |
There was a problem hiding this comment.
Did you want to do this before merging?
There was a problem hiding this comment.
yeah, cool it is changed
src/index.js
Outdated
| @@ -5,35 +5,11 @@ const debugName = 'libp2p:floodsub' | |||
| const log = debug(debugName) | |||
| log.error = debug(`${debugName}:error`) | |||
There was a problem hiding this comment.
Should use this.log instead of creating a new logger
jacobheun
approved these changes
Aug 25, 2020
vasco-santos
removed
the
status/blocked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to libp2p-pubsub v0.6.x
I could not push into @wemeetagain #107 PR, so I got its changes in here, as well as tests updated and now using libp2p in the constructor.
The interface pubsub work is now being used here
Needs: