Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

fix: update interfaces #140

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix: update interfaces #140

merged 2 commits into from
Mar 16, 2022

Conversation

achingbrain
Copy link
Member

Updates to latest code from libp2p/js-libp2p-interfaces#180

Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how did this work before proto encoding? I don't really see removed code.

@achingbrain
Copy link
Member Author

It worked before because the pubsub base class shipped with the protobuf definitions. In the new version it doesn't so extending implementations are free to define the wire type as whatever they need it to be.

Gossipsub already overrides those protobufs, it's just a bit more official now.

@achingbrain achingbrain merged commit c6f622c into master Mar 16, 2022
@achingbrain achingbrain deleted the fix/update-interfaces branch March 16, 2022 16:08
github-actions bot pushed a commit that referenced this pull request Mar 16, 2022
### [1.0.1](v1.0.0...v1.0.1) (2022-03-16)

### Bug Fixes

* update interfaces ([#140](#140)) ([c6f622c](c6f622c))
@github-actions
Copy link

🎉 This PR is included in version 1.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants