Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

fix: remove peer once the peer closes. should fix peer leak #52

Merged
merged 2 commits into from
Dec 5, 2017
Merged

fix: remove peer once the peer closes. should fix peer leak #52

merged 2 commits into from
Dec 5, 2017

Conversation

pgte
Copy link
Contributor

@pgte pgte commented Dec 5, 2017

No description provided.

@ghost ghost assigned pgte Dec 5, 2017
@ghost ghost added the status/in-progress In progress label Dec 5, 2017
@pgte pgte mentioned this pull request Dec 5, 2017
Closed
2 tasks
daviddias
daviddias suggested changes Dec 5, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pgte could you add a test for this?

@pgte
Copy link
Contributor Author

pgte commented Dec 5, 2017

@diasdavid 1516373 adds a test for this.
This particular test fails if run against current master.

@daviddias daviddias merged commit 6e6c507 into master Dec 5, 2017
@daviddias daviddias deleted the fix/peer-leak branch December 5, 2017 20:42
@ghost ghost removed the status/in-progress In progress label Dec 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@pgte pgte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pgte @daviddias