Skip to content
This repository has been archived by the owner on Jun 27, 2023. It is now read-only.

feat: breakout BaseProtocol boilerplate code #57

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

kumavis
Copy link
Contributor

@kumavis kumavis commented Jul 13, 2018

While studying the repo I broke out the boilerplate of managing the connected peers and dialing flow into BaseProtocol. This could be published as a standalone module to help making building protocols easier.

@ghost ghost assigned kumavis Jul 13, 2018
@ghost ghost added the status/in-progress In progress label Jul 13, 2018
@kumavis kumavis changed the title feat: breakout BaseProtocol bootstrapping code feat: breakout BaseProtocol boilerplate code Jul 13, 2018
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@dryajov dryajov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well

@vasco-santos vasco-santos merged commit c4a108d into master Oct 20, 2018
@ghost ghost removed the status/in-progress In progress label Oct 20, 2018
@vasco-santos vasco-santos deleted the feat/breakout-base-protocol branch October 20, 2018 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants