This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
fix: remove use of assert module #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The polyfill is big, we can simulate it by throwing an Error and it doesn't work under React Native.
vasco-santos
suggested changes
Feb 14, 2020
src/index.js
Outdated
| if (typeof registrar !== 'object') { | ||
| throw new Error('a registrar object is required') | ||
| } | ||
| if (typeof registrar.handle !== 'function') { |
There was a problem hiding this comment.
Can we have a function to validate registrar? This way, we would not have the constructor so noisy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The polyfill is big, we can simulate it by throwing an Error and it doesn't work under React Native.