Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

fix: add @types/multicast-dns as dependency #135

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Conversation

wemeetagain
Copy link
Member

Since the types from multicast-dns are exported, the typescript types
must be a full dependency and not just a dev dependency.

Since the types from multicast-dns are exported, the typescript types
must be a full dependency and not just a dev dependency.
@achingbrain
Copy link
Member

Is this due to the .mdns property on the exported class? I think it's only public for the tests, maybe we need a better way to make it testable but not exposed?

@wemeetagain
Copy link
Member Author

Yeah its the mdns property on the exported class

@wemeetagain wemeetagain merged commit 8c855a1 into master Jun 27, 2022
@wemeetagain wemeetagain deleted the fix/add-dependency branch June 27, 2022 17:24
github-actions bot pushed a commit that referenced this pull request Jun 27, 2022
## [2.0.1](v2.0.0...v2.0.1) (2022-06-27)

### Bug Fixes

* add @types/multicast-dns as dependency ([#135](#135)) ([8c855a1](8c855a1))
@github-actions
Copy link

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants