This repository has been archived by the owner on Jul 21, 2023. It is now read-only.
feat: close read and write #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2020
Merged
1 task
1 task
BREAKING CHANGE: close will now close both reading and writing on the stream. It previously only closed for reading, which was not the correct behavior.
jacobheun
force-pushed
the
feat/close-read-write
branch
from
c06dd96
to
22ad25b
Compare
|
Superseded by #121 |
achingbrain
added a commit
that referenced
this pull request
May 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also now throws an error when a write is attempted on a non existent stream. Previously we would just send the message, but this is against the mplex protocol.
This is technically a breaking change due to how
stream.closewas only closing the read end of the stream, which is incorrect behavior.TODO:
Ensure
onEndtriggers for closed streams that haven't been written to yet.requires feat: support for stream muxer closeRead and closeWrite js-libp2p-interfaces#67