Async Crypto Endeavour #108
Conversation
dignifiedquire
force-pushed
the
fast-keys
branch
2 times, most recently
from
a6b7a75 to
aee89e6
Compare
dignifiedquire
force-pushed
the
fast-keys
branch
from
aee89e6 to
d170f89
Compare
| (err, id) => { | ||
| if (err) { | ||
| return cb(err) | ||
| } |
There was a problem hiding this comment.
It would be super beneficial to have a libp2p module libp2p-peer-gen that already has 100 or 1000 PeerId generated and so, each time we request 'one peer', it would be super fast because it only had to load it from disk. We would use this everywhere for testing!
| let peerB | ||
|
|
||
| before((done) => { | ||
| utils.createInfos(2, (err, infos) => { |
There was a problem hiding this comment.
It seems you already went ahead and did what I proposed above. Would you like to make it a module?
| cb() | ||
| }) | ||
| }) | ||
| } |
There was a problem hiding this comment.
Let's make this read from disk instead :)
There was a problem hiding this comment.
okay, will pull out and make its own module with pre generated 100 ids, and if it needs more generate them on the fly
There was a problem hiding this comment.
I've left it in here for now, but it has now ids on disk that it tries to read.
dignifiedquire
force-pushed
the
fast-keys
branch
from
f1478fc to
604a12e
Compare
daviddias
changed the title
done |
Ref libp2p/js-libp2p-crypto#10