fix: use labels to differentiate interfaces for metrics #230
Conversation
Instead of inserting the interface address into the metric name, use the metric address as a label prefix for the value being reported. This allows our metric names to be stable even if you don't know the ip/port combo that will be used ahead of time. The tradeoff is the label names may change between restarts if the port number changes, but we have to apply a disambguator somewhere. Depends on: - [ ] libp2p/js-libp2p-prometheus-metrics#6
|
@achingbrain Should we wait for the libp2p release with updated prometheus metrics before merging this? |
|
No need - this module uses the new metrics interface as of v6 |
I get that, but will it cause perf issues before we update prometheus metrics in libp2p? |
|
Are you talking about using it with the current libp2p release? If so tsc should complain as |
Ah I see! |
## [6.0.4](v6.0.3...v6.0.4) (2022-11-22) ### Bug Fixes * use labels to differentiate interfaces for metrics ([#230](#230)) ([6c4c316](6c4c316))
|
🎉 This PR is included in version 6.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Instead of inserting the interface address into the metric name, use the metric address as a label prefix for the value being reported.
This allows our metric names to be stable even if you don't know the ip/port combo that will be used ahead of time.
The tradeoff is the label names may change between restarts if the port number changes, but we have to apply a disambguator somewhere.
Depends on: