trickle disabled?

[isaackwan]

Is there a reason trickle is disabled?

• https://github.com/libp2p/js-libp2p-webrtc-star/blob/master/src/index.js#L65
• https://github.com/libp2p/js-libp2p-webrtc-star/blob/master/src/index.js#L165

[guysv]

This is the third time I come across this issue, think to myself "hmm, thats a good question", proceed to thumb-up the issue, then realize the existing thumbs-up is mine.

Generally, Trickle-ICE will improve any WebRTC app performance, so we should use it.

I can only guess that utilizing trickle ice will complicate the negotiation protocol. That is solvable, but i'm worried about the next-gen webrtc-star.

Trickle-ICE requires multiple messaging rounds, but interface-data-exchange only supports a single request-response.
@mkg20001 whats your take on this?

[mkg20001]

We could do multiple req/res cycles in data-exchange. Once everything gets switched over to async/await this shouldn't be a problem anymore. But adding a transport handler for handeling subsequent request/responses might inflate complexity too much, so it might be a good idea to use a "clever hack" here, by adding a seperate listener for the second round, under a different name, so that the complexity is moved into the webrtc-star transport and not data-exchange.

So first a req/res cycle is done for webrtc handler, then req/res is done for webrtc-trickle handler which gets the needed data by a request id that gets thrown into the response from the other side in the first cycle and is used in an object to get data from the webrtc handler to the webrtc-trickle handler that isn't already sent over the wire. Sounds sane?