This repository has been archived by the owner on Apr 24, 2023. It is now read-only.
Adds install/set up instructions to the readme. #435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnnymatthews
commented
May 24, 2022
achingbrain
suggested changes
May 31, 2022
| 1. Install the local `@libp2p` package: | ||
|
|
||
| ```shell | ||
| npm install -g @libp2p/webrtc-star-signalling-server |
There was a problem hiding this comment.
This will install the current release version of @libp2p/webrtc-star-signalling-server and not the one from this repo.
If you want the release version you could skip steps 1 & 2.
If you want the version from this repo you need to npm i after step 2, then npm link in the signalling server folder.
As it stands this duplicates the installation instructions from the webrtc-star-signalling-server package README, you could just link to them?
|
I'm going to close this so we can look at the root issue again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.