This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
fix: added peer connection state listener to emit closed events #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddimaria
reviewed
Apr 24, 2023
MarcoPolo
reviewed
Apr 25, 2023
| @@ -183,13 +184,30 @@ export class WebRTCDirectTransport implements Transport { | |||
| } | |||
| } | |||
|
|
|||
| const eventListeningName = isFirefox ? 'iceconnectionstatechange' : 'connectionstatechange' | |||
There was a problem hiding this comment.
Generally it's better to check if a capability is present or not. But that being said, I'm not sure off the top of my head how I would check for this. So I think it's okay.
There was a problem hiding this comment.
Good point, well iceconnectionstatechange event has been supported since Firefox 24 which is about a decade old, and connectionstatechange has been supported for at least two years in all other browsers, so I would say this is low risk.
MarcoPolo
reviewed
Apr 25, 2023
MarcoPolo
approved these changes
Apr 25, 2023
|
🎉 This PR is included in version 1.1.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RTCPeerConnectionstate is not being monitored, as a result thepeer:Disconnectevent which is triggered by aconnectionEndevent is not fired, resulting in closed connections not being properly propogated.We can listen for disconnect events using the RTCPeerConnection connectionstatechange event
Closes: #138