This repository has been archived by the owner on Feb 26, 2021. It is now read-only.
Review of WebSocket Star #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
daviddias
commented
Sep 8, 2017
•
daviddias
commented
mkg20001
reviewed
Sep 8, 2017
package.json
Outdated
| @@ -4,13 +4,13 @@ | |||
| "description": "libp2p-webrtc-star without webrtc. Just plain socket.io.", | |||
| "main": "src/index.js", | |||
| "bin": { | |||
| "websockets-star": "src/rendezvous/bin.js", | |||
| "websockets-star": "src/rendezvous/bin.js" | |||
There was a problem hiding this comment.
answered in the issue #11 (comment)
mkg20001
reviewed
Sep 8, 2017
package.json
Outdated
| @@ -32,13 +32,18 @@ | |||
| "async": "^2.5.0", | |||
| "data-queue": "0.0.2", | |||
| "debug": "^3.0.1", | |||
| "hapi": "^16.5.2", | |||
There was a problem hiding this comment.
Can't we have those modules split up in client and server? Putting hapi and socket.io into this module only makes the client 10x bigger without any benefits for the user.
Edit: That's what #11 was about
There was a problem hiding this comment.
Ok, we can do that then.
There was a problem hiding this comment.
|
I won't have time to look into this again until tomorrow. @mkg20001 if you want to take a stab at continuing modularizing and making sure everything is wired together now that the rendezvous service was factor out, be my guest :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.