Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node and npm versions in package.json #1745

Closed
zeroxbt opened this issue May 7, 2023 · 3 comments
Closed

Node and npm versions in package.json #1745

zeroxbt opened this issue May 7, 2023 · 3 comments
Labels
need/triage Needs initial labeling and prioritization

Comments

@zeroxbt
Copy link
Contributor

zeroxbt commented May 7, 2023

  • Version: 0.44
  • Platform:
  • Subsystem:

Severity: Low

Description:

When installing dependencies with node v16 as specified in package.json, the warning:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'semantic-release@20.1.3',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.15.1', npm: '8.11.0' }
npm WARN EBADENGINE }

is printed in the console as one of the dependencies requires node v18.

Shouldn't "engines" be updated in package.json ?

Steps to reproduce the error:

npm install using nodejs v16

@zeroxbt zeroxbt added the need/triage Needs initial labeling and prioritization label May 7, 2023
@maschad
Copy link
Member

maschad commented May 8, 2023

Thanks for raising this, it seems to be related to a transitive dependency that we use for automating our releases through project management tool, perhaps we should update it there since aegir is a devDependency Would you like to open a PR?

@zeroxbt
Copy link
Contributor Author

zeroxbt commented May 8, 2023

Hi @maschad , thanks for the reply. It looks like this is already being worked on by @achingbrain

https://github.com/ipfs/aegir/tree/fix/min-node-version

@zeroxbt
Copy link
Contributor Author

zeroxbt commented May 10, 2023

Closing as it was fixed by this PR.

@zeroxbt zeroxbt closed this as completed May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants