Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'peer:discovery' event does not always emit a valid PeerInfo #1873

Closed
wemeetagain opened this issue Jul 10, 2023 · 0 comments · Fixed by #1902
Closed

'peer:discovery' event does not always emit a valid PeerInfo #1873

wemeetagain opened this issue Jul 10, 2023 · 0 comments · Fixed by #1902
Assignees
@maschad
Labels
need/triage Needs initial labeling and prioritization

Comments

@wemeetagain
Copy link
Member

  • Version:

0.45.9

  • Subsystem:

libp2p

Severity:

low/medium

Description:

It seems that 'peer:discovery' does not always emit a full PeerInfo.
We've seen multiaddrs being undefined, even though the type is Multiaddr[].

Steps to reproduce the error:

See ChainSafe/lodestar#5736
@wemeetagain wemeetagain added the need/triage Needs initial labeling and prioritization label Jul 10, 2023
@wemeetagain wemeetagain changed the title 'peer:discovery event does not always emit a valid PeerInfo 'peer:discovery' event does not always emit a valid PeerInfo Jul 10, 2023
@maschad maschad self-assigned this Jul 17, 2023
@maschad maschad moved this to 🤨Needs Investigation in js-libp2p Jul 17, 2023
@maschad maschad moved this from 🤨Needs Investigation to 🛠️ Todo in js-libp2p Jul 24, 2023
maschad added a commit to maschad/js-libp2p that referenced this issue Jul 26, 2023
@maschad
fix: ignore peers with invalid multiaddrs (libp2p#1873)
e01ef31
@maschad maschad mentioned this issue Jul 26, 2023
Merged
@maschad maschad moved this from 🛠️ Todo to 🥸In Review in js-libp2p Jul 28, 2023
@github-project-automation github-project-automation bot moved this from 🥸In Review to 🎉Done in js-libp2p Jul 30, 2023
achingbrain added a commit that referenced this issue Jul 30, 2023
@maschad @achingbrain
fix: ignore peers with invalid multiaddrs (#1902)
a41d25d 
It's necessary to convert `.addresses` to `.multiaddrs` to conform to the `PeerInfo` interface.

Closes #1873

---------

Co-authored-by: Alex Potsides <alex@achingbrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maschad maschad

Labels
need/triage Needs initial labeling and prioritization
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ignore peers with invalid multiaddrs maschad/js-libp2p
2 participants
@wemeetagain @maschad