-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to @chainsafe/is-ip (away from @achingbrain/ip-address) #1926
Comments
w.r.t. BigInt we're using https://www.npmjs.com/package/protons, which uses |
Not generally no, outside of "it works" and "it doesn't cause enough problems to bring eyeballs to it". Since this is now starting to cause problems I think we can switch it out for @chainsafe/is-ip which we use elsewhere in the stack. |
…ddress The `@achingbrain/ip-address` module is a fork of `ip-address` which seems to have dependencies on older modules that break modern runtimes like react native. `@Chainsafe/is-ip` does not have these limitations so switch to that. Fixes #1926
The `@achingbrain/ip-address` module is a fork of `ip-address` which seems to have dependencies on older modules that break modern runtimes like react native. `@Chainsafe/is-ip` does not have these limitations so switch to that. Fixes #1926
Is there a reason why we're still using
@achingbrain/ip-address
, or even ip-address, when it's outdated? There seem to be better and more up to date alternatives: https://npmtrends.com/ip-vs-ip-address-vs-ipaddr.js. Though maybe they don't do everything we need them to?One of
ip-address
's dependencies,jsbn
, is very stale and very underused in comparison to it's competitors: https://npmtrends.com/bignumber.js-vs-bn-vs-bn.js-vs-jsbnThere is also the native BigInt which has been around for a while: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
We only seem to have a very small surface area for each here:
I also seem to remember some concerns around node-forge being used in js-libp2p and this may be another place where we could reduce our ties to it.
I'm not aware of the nuances but generally if a project leaves a PR that we need (beaugunderson/ip-address#148) untouched for over a year (it's going on 2), and we still don't have a permanent place to modify code for our patched version, we should probably think about migrating, or publishing our version.
cc @achingbrain. related to ipfs/helia#73 (comment)
The text was updated successfully, but these errors were encountered: