fix(transports): filter circuit addresses #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use exact matchers for filtering webtransport and webrtc addresses so those transports do not try to dial (for example) p2p-circuit addresses, instead leaving the more specific address to other transports.
maschad
approved these changes
Sep 19, 2023
SgtPooki
approved these changes
Sep 19, 2023
|
|
||
| it('transport filter filters out invalid multiaddrs', async () => { | ||
| const valid = [ | ||
| multiaddr('/ip4/1.2.3.4/udp/1234/quic-v1/webtransport/certhash/uEiAUqV7kzvM1wI5DYDc1RbcekYVmXli_Qprlw3IkiEg6tQ/certhash/uEiAUqV7kzvM1wI5DYDc1RbcekYVmXli_Qprlw3IkiEg6tQ/p2p/12D3KooWGDMwwqrpcYKpKCgxuKT2NfqPqa94QnkoBBpqvCaiCzWd') |
There was a problem hiding this comment.
Should we add a webtransport relay address here?
There was a problem hiding this comment.
The first entry in the invalid array is a webtransport relay address, unless I'm misunderstanding you. Maybe suggest an edit?
There was a problem hiding this comment.
Suggested change
| multiaddr('/ip4/1.2.3.4/udp/1234/quic-v1/webtransport/certhash/uEiAUqV7kzvM1wI5DYDc1RbcekYVmXli_Qprlw3IkiEg6tQ/certhash/uEiAUqV7kzvM1wI5DYDc1RbcekYVmXli_Qprlw3IkiEg6tQ/p2p/12D3KooWGDMwwqrpcYKpKCgxuKT2NfqPqa94QnkoBBpqvCaiCzWd') | |
| multiaddr('/ip4/1.2.3.4/udp/1234/quic-v1/webtransport/certhash/uEiAUqV7kzvM1wI5DYDc1RbcekYVmXli_Qprlw3IkiEg6tQ/certhash/uEiAUqV7kzvM1wI5DYDc1RbcekYVmXli_Qprlw3IkiEg6tQ/p2p/12D3KooWGDMwwqrpcYKpKCgxuKT2NfqPqa94QnkoBBpqvCaiCzWd'), | |
| multiaddr('/ip4/167.235.53.235/udp/4001/quic-v1/webtransport/certhash/uEiDCKMoprQ0dsmyQ874-yN7h5Nwd1NVMFTeW5Rgg6RXD3Q/certhash/uEiBBN1_poJQS1J7pkbR7nDsFqFjRgrN51RuBlXsgwdA4Ag/p2p/12D3KooWPKRSU7mX3JiiasLBKYsFhPgiGZNcdv5SxBZrbrU7C8Jw/p2p-circuit/p2p/12D3KooWRG7hywMqYLDWh6EhzoYn5nUMJnHytjjuEK4UvKu2b1JQ') |
or into invalid addresses if that's where it belongs
There was a problem hiding this comment.
Is this not the same sort of address as the first entry in the invalid list?
achingbrain
changed the title
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Sep 27, 2023
Use exact matchers for filtering webtransport and webrtc addresses so those transports do not try to dial (for example) p2p-circuit addresses, instead leaving the more specific address to other transports.
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use exact matchers for filtering webtransport and webrtc addresses so those transports do not try to dial (for example) p2p-circuit addresses, instead leaving the more specific address to other transports.
Refs: ipfs/helia#267