feat: collect dial/listen metrics in webrtc and webtransport #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the documented libp2p metrics system to collect metrics for the webrtc and webtransport transports
maschad
approved these changes
Sep 19, 2023
SgtPooki
approved these changes
Sep 19, 2023
Comment on lines
96
to
114
| wt.close(closeInfo) | ||
| this.metrics?.dialerEvents.increment({ close: true }) | ||
| wt.close() |
There was a problem hiding this comment.
We use it as a cheap error object, but that's not what it does and it affects the WebTransport after closing.
From step 9 in the cleanup procedure:
If closeInfo is given, then set transport.[[State]] to "closed". Otherwise, set transport.[[State]] to "failed".
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Sep 27, 2023
…2061) Use the documented libp2p metrics system to collect metrics for the webrtc and webtransport transports
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the documented libp2p metrics system to collect metrics for the webrtc and webtransport transports