Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure mock stream output is uint8arraylist #2209

Merged
merged 1 commit into from
Nov 7, 2023
Merged

fix: ensure mock stream output is uint8arraylist #2209

merged 1 commit into from
Nov 7, 2023

Conversation

achingbrain
Copy link
Member

When using mock streams pairs, we use a simple duplex to pass the input of one to the output of the other.

The input can be a Uint8Array or a Uint8ArrayList but the output can only be Uint8ArrayList so ensure we output the correct type.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: ensure mock stream output is uint8arraylist
b2fc444 
When using mock streams pairs, we use a simple duplex to pass the
input of one to the output of the other.

The input can be a `Uint8Array` or a `Uint8ArrayList` but the output
can only be `Uint8ArrayList` so ensure we output the correct type.
@achingbrain achingbrain requested a review from a team as a code owner November 7, 2023 11:01
@achingbrain achingbrain merged commit 8b82e68 into master Nov 7, 2023
22 checks passed
@achingbrain achingbrain deleted the fix/ensure-output-is-uint8arraylist branch November 7, 2023 11:23
maschad pushed a commit to maschad/js-libp2p that referenced this pull request Nov 10, 2023
@achingbrain @maschad
fix: ensure mock stream output is uint8arraylist (libp2p#2209)
8868560 
When using mock streams pairs, we use a simple duplex to pass the
input of one to the output of the other.

The input can be a `Uint8Array` or a `Uint8ArrayList` but the output
can only be `Uint8ArrayList` so ensure we output the correct type.
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain