Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore peers with invalid multiaddrs #1902

Merged
merged 7 commits into from
Jul 30, 2023
Merged

fix: ignore peers with invalid multiaddrs #1902

Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e01ef31
fix: ignore peers with invalid multiaddrs (#1873)
maschad Jul 26, 2023
906256b
Merge branch 'master' into fix/peer-discovery-emits-multiaddr
maschad Jul 28, 2023
933b06d
chore: linting
maschad Jul 28, 2023
57a5ba9
Merge branch 'master' into fix/peer-discovery-emits-multiaddr
achingbrain Jul 28, 2023
13b653e
Merge branch 'master' into fix/peer-discovery-emits-multiaddr
achingbrain Jul 29, 2023
21f7719
fix: do double equals to cover undefined values (#1872)
maschad Jul 29, 2023
c07cf1b
Merge branch 'master' into fix/peer-discovery-emits-multiaddr
maschad Jul 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions packages/libp2p/src/libp2p.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,14 @@ export class Libp2pNode<T extends ServiceMap = Record<string, unknown>> extends

components.events.addEventListener('peer:update', evt => {
// if there was no peer previously in the peer store this is a new peer
if (evt.detail.previous == null) {
this.safeDispatchEvent('peer:discovery', { detail: evt.detail.peer })
if (evt.detail.previous === null) {
maschad marked this conversation as resolved.
Show resolved Hide resolved
const peerInfo: PeerInfo = {
id: evt.detail.peer.id,
multiaddrs: evt.detail.peer.addresses.map(a => a.multiaddr),
protocols: evt.detail.peer.protocols
}

this.safeDispatchEvent('peer:discovery', { detail: peerInfo })
}
})

Expand Down