Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: opt-in to toplogy notifications on transient connections #2049

Commits on Sep 13, 2023

  1. fix(libp2p): opt-in to toplogy notifications on transient connections

    Adds a `notifyOnTransient` option when registering a network topology
    to opt-in to being notified when peers that support the registered
    protocol connect over transient connections.  False by default.
    
    The logic has been switched to notify after identify has completed
    rather than after the first connection for a peer has been opened.
    
    The side effect here is that if `notifyOnTransient` is true, and the
    peer ends up opening a direct connection (for example they dial us
    via circuit relay, open a stream to do the WebRTC SDP exchange, then
    open a WebRTC connection), identify will run on the second connection
    so the topology will receive two notificiations.
    
    This is not a breaking change since the previous behaviour would have
    been to only notify on the transient connection, which is probably a
    bug as you can't do data-heavy things like bitswap over transient
    connections so is undesirable.
    
    Fixes #2036
    achingbrain committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    0cbd823 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Configuration menu
    Copy the full SHA
    037bf61 View commit details
    Browse the repository at this point in the history
  2. chore: fix tests

    achingbrain committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    2322dce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d8cae9b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    95f3f75 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2636a08 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Merge remote-tracking branch 'origin/master' into fix/opt-in-to-toplo…

    …gy-notifications-on-transient-connections
    achingbrain committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    c069c1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cfee990 View commit details
    Browse the repository at this point in the history
  3. chore: fix linting

    achingbrain committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    539fdc2 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2023

  1. Merge remote-tracking branch 'origin/master' into fix/opt-in-to-toplo…

    …gy-notifications-on-transient-connections
    achingbrain committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    f67364f View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    a47d1dc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b2f8d0d View commit details
    Browse the repository at this point in the history
  3. chore: fix interop test

    achingbrain committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    0dbe592 View commit details
    Browse the repository at this point in the history
  4. chore: fix interop, again

    achingbrain committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    bb28354 View commit details
    Browse the repository at this point in the history