-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: opt-in to toplogy notifications on transient connections #2049
fix: opt-in to toplogy notifications on transient connections #2049
Commits on Sep 13, 2023
-
fix(libp2p): opt-in to toplogy notifications on transient connections
Adds a `notifyOnTransient` option when registering a network topology to opt-in to being notified when peers that support the registered protocol connect over transient connections. False by default. The logic has been switched to notify after identify has completed rather than after the first connection for a peer has been opened. The side effect here is that if `notifyOnTransient` is true, and the peer ends up opening a direct connection (for example they dial us via circuit relay, open a stream to do the WebRTC SDP exchange, then open a WebRTC connection), identify will run on the second connection so the topology will receive two notificiations. This is not a breaking change since the previous behaviour would have been to only notify on the transient connection, which is probably a bug as you can't do data-heavy things like bitswap over transient connections so is undesirable. Fixes #2036
Configuration menu - View commit details
-
Copy full SHA for 0cbd823 - Browse repository at this point
Copy the full SHA 0cbd823View commit details
Commits on Sep 15, 2023
-
Merge branch 'master' into fix/opt-in-to-toplogy-notifications-on-tra…
…nsient-connections
Configuration menu - View commit details
-
Copy full SHA for 037bf61 - Browse repository at this point
Copy the full SHA 037bf61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2322dce - Browse repository at this point
Copy the full SHA 2322dceView commit details -
Merge branch 'master' into fix/opt-in-to-toplogy-notifications-on-tra…
…nsient-connections
Configuration menu - View commit details
-
Copy full SHA for d8cae9b - Browse repository at this point
Copy the full SHA d8cae9bView commit details -
Merge branch 'master' into fix/opt-in-to-toplogy-notifications-on-tra…
…nsient-connections
Configuration menu - View commit details
-
Copy full SHA for 95f3f75 - Browse repository at this point
Copy the full SHA 95f3f75View commit details -
Merge branch 'master' into fix/opt-in-to-toplogy-notifications-on-tra…
…nsient-connections
Configuration menu - View commit details
-
Copy full SHA for 2636a08 - Browse repository at this point
Copy the full SHA 2636a08View commit details
Commits on Oct 13, 2023
-
Merge remote-tracking branch 'origin/master' into fix/opt-in-to-toplo…
…gy-notifications-on-transient-connections
Configuration menu - View commit details
-
Copy full SHA for c069c1b - Browse repository at this point
Copy the full SHA c069c1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cfee990 - Browse repository at this point
Copy the full SHA cfee990View commit details -
Configuration menu - View commit details
-
Copy full SHA for 539fdc2 - Browse repository at this point
Copy the full SHA 539fdc2View commit details
Commits on Oct 27, 2023
-
Merge remote-tracking branch 'origin/master' into fix/opt-in-to-toplo…
…gy-notifications-on-transient-connections
Configuration menu - View commit details
-
Copy full SHA for f67364f - Browse repository at this point
Copy the full SHA f67364fView commit details
Commits on Oct 31, 2023
-
Merge branch 'master' into fix/opt-in-to-toplogy-notifications-on-tra…
…nsient-connections
Configuration menu - View commit details
-
Copy full SHA for a47d1dc - Browse repository at this point
Copy the full SHA a47d1dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2f8d0d - Browse repository at this point
Copy the full SHA b2f8d0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0dbe592 - Browse repository at this point
Copy the full SHA 0dbe592View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb28354 - Browse repository at this point
Copy the full SHA bb28354View commit details