refactor!: remove libp2p.keychain #2084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please hold off merging breaking changes until we resolve WebRTC stream closing |
Closed
maschad
dismissed
their stale review
Let's review and merge this once #2104 is resolved.
achingbrain
requested changes
Oct 10, 2023
achingbrain
requested changes
Oct 12, 2023
maschad
approved these changes
Oct 14, 2023
achingbrain
added a commit
that referenced
this pull request
Oct 31, 2023
* refactor!: remove libp2p.keychain * chore: remove @libp2p/keychain dep from libp2p * chore: add migration documentation --------- Co-authored-by: Alex Potsides <alex@achingbrain.net>
achingbrain
pushed a commit
that referenced
this pull request
Oct 31, 2023
Extract the keychain into it's own package.
achingbrain
pushed a commit
that referenced
this pull request
Nov 3, 2023
Extract the keychain into it's own package.
achingbrain
pushed a commit
that referenced
this pull request
Nov 7, 2023
Extract the keychain into it's own package.
achingbrain
pushed a commit
that referenced
this pull request
Nov 8, 2023
Extract the keychain into it's own package.
achingbrain
pushed a commit
that referenced
this pull request
Nov 10, 2023
Extract the keychain into it's own package.
maschad
pushed a commit
to maschad/js-libp2p
that referenced
this pull request
Nov 10, 2023
Extract the keychain into it's own package.
achingbrain
pushed a commit
that referenced
this pull request
Nov 15, 2023
Extract the keychain into it's own package.
Closed
Merged
Closed
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Libp2pinterface andLibp2pNodeimplementationDuring an in-person discussion, it was found that the keychain has limited use and value being bundled in libp2p.
The rationale is that libp2p should bundle with only functionality required to run its internal machinery related to managing connections, streams, protocols, etc.
The Keychain interface and implementation have NOT been removed, they've been kept. So, users of the Keychain can instantiate one in their application and continue using it.
Change checklist