Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: remove isStarted method from Startable #2145

Merged
merged 2 commits into from
Oct 25, 2023
Merged

refactor!: remove isStarted method from Startable #2145

merged 2 commits into from
Oct 25, 2023

Commits on Oct 10, 2023

  1. refactor!: remove isStarted method from Startable 

    We have an `isStarted` method on the `Startable` interface but we only
really use it in tests. Our implementations tend to guard on being
started twice so it just adds noise to every implementation.

BREAKING CHANGE: the `isStarted` method has been removed from the `Startable` interface
    @achingbrain
    achingbrain committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    dc9955a View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. chore: add missed changes

    @achingbrain
    achingbrain committed Oct 12, 2023
    Configuration menu
    Copy the full SHA
    2692700 View commit details
    Browse the repository at this point in the history