Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow certain keychain operations without a password #726

Merged
merged 3 commits into from
Aug 5, 2020
Merged

fix: allow certain keychain operations without a password #726

merged 3 commits into from
Aug 5, 2020

Commits on Aug 5, 2020

  1. fix: allow certain keychain operations without a password 

    Listing, removing, renaming etc keys do not require a password so
the user should not be required to provide one.

This means we don't have to prompt the user to create a password
when they aren't going to do any operations that require a password.
    @achingbrain @jacobheun
    achingbrain authored and jacobheun committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    5a8793b View commit details
    Browse the repository at this point in the history

  2. fix: make keychain pass optional

    @jacobheun
    jacobheun committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    80f015e View commit details
    Browse the repository at this point in the history

  3. fix: support libp2p creation without keychain pass

    @jacobheun
    jacobheun committed Aug 5, 2020
    Configuration menu
    Copy the full SHA
    386c3d3 View commit details
    Browse the repository at this point in the history