Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

fix: remove use of assert module #88

Merged
merged 1 commit into from
Feb 13, 2020
Merged

fix: remove use of assert module #88

merged 1 commit into from
Feb 13, 2020

Conversation

achingbrain
Copy link
Member

The polyfill is big, we can simulate it by throwing an Error and it doesn't work under React Native.

@achingbrain
fix: remove use of assert module
5f8ef91 
The polyfill is big, we can simulate it by throwing an Error and
it doesn't work under React Native.
jacobheun
jacobheun approved these changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vasco-santos
vasco-santos approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

We have several other modules using assert, we need to make sure we remove them

@vasco-santos vasco-santos merged commit a0613c5 into master Feb 13, 2020
@vasco-santos vasco-santos deleted the remove-use-of-assert branch February 13, 2020 16:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@jacobheun jacobheun jacobheun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achingbrain @jacobheun @vasco-santos