Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Swarm doesn't expose connection info #1084

Closed
tomaka opened this issue Apr 23, 2019 · 1 comment · Fixed by #1172
Closed

The Swarm doesn't expose connection info #1084

tomaka opened this issue Apr 23, 2019 · 1 comment · Fixed by #1172
Labels
difficulty:moderate priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@tomaka
Copy link
Member

tomaka commented Apr 23, 2019

The RawSwarm can be parametrized over the connection info, but the Swarm hard-codes it to PeerId at the moment.

I don't know what the right solution to this is, except change NetworkBehaviour.
@tomaka tomaka added priority:important The changes needed are critical for libp2p, or are blocking another project difficulty:moderate labels Apr 23, 2019
@tomaka tomaka mentioned this issue Jun 11, 2019
Merged
@tomaka
Copy link
Member Author

tomaka commented Jun 11, 2019

I initially wrote in #1030 that it was necessary in order to tackle paritytech/substrate#271. However #1030 is trickier, and I think that this issue is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow customizing the Swarm with TConnInfo tomaka/libp2p-rs
1 participant
@tomaka