Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the protocol.rs file in Kademlia to be more straight-forward #1104

Closed
tomaka opened this issue May 6, 2019 · 2 comments
Closed

Rewrite the protocol.rs file in Kademlia to be more straight-forward #1104

tomaka opened this issue May 6, 2019 · 2 comments
Labels
difficulty:moderate priority:nicetohave

Comments

@tomaka
Copy link
Member

tomaka commented May 6, 2019

The current protocol.rs is quite complex because of backwards-compatibility reasons from a time where we implemented the Kademlia is a way that's incompatible with go-libp2p and js-libp2p.

This was a very long time ago, and it should now be possible to remove this backwards compatibility code and replace it with more straight-forward code.
Inspiration can be taken from the protocol.rs file in Floodsub.
@tomaka
Copy link
Member Author

tomaka commented Apr 30, 2020

This could be done on top of #1562

@romanb romanb mentioned this issue Jul 1, 2020
Closed
@thomaseizinger
Copy link
Contributor

Closed in favor of #3130.

@thomaseizinger thomaseizinger closed this as not planned Won't fix, can't repro, duplicate, stale Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:moderate priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomaka @thomaseizinger