Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace code-gen macros in tcp and uds with async-io #1787

Closed
dvc94ch opened this issue Oct 7, 2020 · 2 comments
Closed

replace code-gen macros in tcp and uds with async-io #1787

dvc94ch opened this issue Oct 7, 2020 · 2 comments

Comments

@dvc94ch
Copy link
Contributor

dvc94ch commented Oct 7, 2020

While working on refactoring the transport trait to accomodate quic or port reuse in tcp, it seemed like the code needs some maintainance. I think async-io should work fine for any executor, so the TokioTcp and Tcp stuff can be simplified to just Tcp. Unless there are any objections I'll submit a PR as soon as smol-rs/async-io#36 gets fixed.
@dvc94ch dvc94ch mentioned this issue Oct 9, 2020
Closed
8 tasks
@ericjmiller
Copy link

I think this could affect implementation of #1820.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Mar 22, 2021

This issue was resolved I guess.

@dvc94ch dvc94ch closed this as completed Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Transport trait dvc94ch/rust-libp2p
2 participants
@dvc94ch @ericjmiller