Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly send a close message for mplex substreams #313

Closed
tomaka opened this issue Jul 17, 2018 · 2 comments
Closed

Properly send a close message for mplex substreams #313

tomaka opened this issue Jul 17, 2018 · 2 comments

Comments

@tomaka
Copy link
Member

tomaka commented Jul 17, 2018

When an mplex substream is dropped, we try to send a close message to the remote.
However if the current output buffer is full, the message will not get through.

@tomaka
Copy link
Member Author

tomaka commented Mar 22, 2019

Some things have changed in mplex, but this issue is still there.

If we destroy a substream with destroy_substream and this substream was still open, we currently don't notify the remote. Instead we should send a Reset message.

There's still the problem that destroy_substream must return instantly, therefore we can't return NotReady, and we need to add some sort of send buffer.

@romanb
Copy link
Contributor

romanb commented Oct 2, 2020

Closed by #1769.

@romanb romanb closed this as completed Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants