Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message ordering is not maintained in Gossipsub #4424

Open
dvasanth opened this issue Sep 2, 2023 · 1 comment
Open

Message ordering is not maintained in Gossipsub #4424

dvasanth opened this issue Sep 2, 2023 · 1 comment

Comments

@dvasanth
Copy link

dvasanth commented Sep 2, 2023

Summary

Previous version of Gossipsub messages had some message sequence ordering. With newer latest 0.52.3 version, the ordering is always wrong.

Expected behaviour

Expecting the messages published for a topic to be in order or at least provide a sequence id to help the application order the messages.

Actual behaviour

Messages published in Gossipsub received always out of sequence.

Possible Solution

Instead of having random message Id it can have a sequence number to help application order it. Security risks due to linear message Ids can be avoided with other mechanisms.

Version

libp2p = { version = "^0.52.3", features = ["full"] }
I think there is some changes introduced that affects the ordering.

Would you like to work on fixing this bug?

Yes.

@dvasanth dvasanth changed the title Message sequence is not maintained in Gossipsub Message ordering is not maintained in Gossipsub Sep 2, 2023
@thomaseizinger
Copy link
Contributor

I think what you are looking for is #3551. If you use signed messages, you'll get sequential IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants