Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identify: multiple Push messages are racy #501

Open
marten-seemann opened this issue Jan 2, 2023 · 0 comments · May be fixed by #502
Open

identify: multiple Push messages are racy #501

marten-seemann opened this issue Jan 2, 2023 · 0 comments · May be fixed by #502

Comments

@marten-seemann
Copy link
Contributor

When a peer send multiple Identify push messages in succession, the outcome of this will be racy, since there's no ordering guarantee between the two Identify Push streams.

This can easily be solved by adding a sequence number to the Identify message.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
libp2p Specs
Status: Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

identify: add a sequence number to the Identify protobuf libp2p/specs
1 participant
@marten-seemann