-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename repository to interop
#109
Comments
Agreed. Lower priority for me, but I like it. To list what else would have to change:
|
Does |
Good point, I am okay with |
Is doing this still worthwhile? I think it's a nice distinction to make and allows us to leave test-plans in the past but it also might be harder to pull off with the way testing is embedded in repo |
I am almost certain that GitHub creates redirects if you rename a repo. Alternatively, we can just push it under a new name, update all implementation repositories and then delete this one. |
Yes, GitHub creates a redirect, I recently went through this process when I migrated quic-go to its own org. It still makes sense to update implementations to use the correct path. That said, are we getting a lot out of a renaming? |
With the redirect, the good news is that we don't have to do anything in lockstep, thus my point would be that a more expressive name is worth it. Let's set a deadline for end of June. Regarding the actual name, what I most commonly hear from people in conversations is I'd consider hole-punching tests more on the functional side rather than on the interop side. With the addition of the performance benchmarks, one could even debate whether "tests" is the right category for all of this. Just |
That sounds good.
It is cosmetic but why keep referring to test-plans when Testground is no longer used. It also is more evident to newcomers (new implementation adding their interop tests). |
interop-tests
interop
|
Suggestion to change
test-plans
tointerop-tests
everywhere. I think it is more expressive in what these tests are testing.The text was updated successfully, but these errors were encountered: