fix(perf): run iperf on TCP and set TCP windows to bdp #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes iperf use TCP instead of UDP. Using UDP allows the sender to send as much data as they can, not as much data as the receiver can handle. Using TCP measures the actual bandwidth of the connection. This commit sets the TCP send and receive window to the bandwidth-delay-product. In order to exhaust the whole bandwidth between the two nodes, TCP needs to be able to buffer all bytes on the wire in the case of packet loss.
mxinden
changed the title
|
Addresses some of #222. |
|
Before (low https with median 301 Mbit/s)
https://observablehq.com/@libp2p-workspace/performance-dashboard after (high https with median 781 Mbit/s)
https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=perf-iperf-tcp |
|
Pending perf GitHub CI Action run: https://github.com/libp2p/test-plans/actions/runs/5726937426/job/15518354294 Edit: Done |
|
@MarcoPolo @marten-seemann can one of you give this a review? |
marten-seemann
approved these changes
Aug 1, 2023
| # machines, the bandwidth-delay-product is ~178.81 MiB. Set send and receive | ||
| # window to 200 MiB. | ||
| sudo sysctl -w net.ipv4.tcp_rmem='4096 131072 200000000' | ||
| sudo sysctl -w net.ipv4.tcp_wmem='4096 20480 200000000' |
There was a problem hiding this comment.
Do I understand correctly that this is set for every run, not just for iperf?
There was a problem hiding this comment.
Correct. This set on startup on both machines and is thus set for all benchmarks, all implementations and all versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes iperf use TCP instead of UDP. Using UDP allows the sender to send as much data as they can, not as much data as the receiver can handle. Using TCP measures the actual bandwidth of the connection.
This commit sets the TCP send and receive window to the bandwidth-delay-product. In order to exhaust the whole bandwidth between the two nodes, TCP needs to be able to buffer all bytes on the wire in the case of packet loss.