Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust cli flags for perf runner for testing purposes #275

Merged
merged 3 commits into from
Sep 1, 2023

Conversation

maschad
Copy link
Member

@maschad maschad commented Aug 24, 2023

Follow up PR related to #258

Based on @mxinden 's comments regarding the perf runner

Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thank you!

perf/README.md Outdated Show resolved Hide resolved
Co-authored-by: Max Inden <mail@max-inden.de>
@mxinden mxinden merged commit fbb92b7 into libp2p:master Sep 1, 2023
@achingbrain
Copy link
Member

Not sure why, maybe I'm not doing it right, but when I set testing to true, suddenly the runner can't find the iperf3 binary:

= run 1 iPerf TCP from client to server
Warning: Permanently added '54.191.84.202' (ED25519) to the list of known hosts.
cat: pidfile: No such file or directory
kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... or kill -l [sigspec]
rm: cannot remove 'pidfile': No such file or directory
rm: cannot remove 'server.log': No such file or directory


bash: line 1: iperf3: command not found
Error: Command failed: ssh -o StrictHostKeyChecking=no ec2-user@3.95.55.203 'iperf3 -c 54.191.84.202 -t 1 -N'
bash: line 1: iperf3: command not found

https://github.com/libp2p/test-plans/actions/runs/6904729515/job/18785974329

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants