Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perf): use noise for encryption on js-libp2p perf runs #281

Closed
wants to merge 2 commits into from

Conversation

maschad
Copy link
Member

@maschad maschad commented Aug 25, 2023

@libp2p/perf v1.1.4 now utilizes noise protocol for encryption as suggested by @mxinden

Related libp2p/js-libp2p#1991

@maschad
Copy link
Member Author

maschad commented Aug 29, 2023

@mxinden would you be able to trigger a run for to test this?

@p-shahi
Copy link
Member

p-shahi commented Aug 30, 2023

Triggered https://github.com/libp2p/test-plans/actions/runs/6030793098 on js-libp2p-noise-encryption branch

@maschad
Copy link
Member Author

maschad commented Aug 31, 2023

Triggered libp2p/test-plans/actions/runs/6030793098 on js-libp2p-noise-encryption branch

Looks like a broken pipe error on rust v0.52 caused this to fail, any ideas @mxinden @thomaseizinger ?

@thomaseizinger
Copy link
Contributor

Triggered libp2p/test-plans/actions/runs/6030793098 on js-libp2p-noise-encryption branch

Looks like a broken pipe error on rust v0.52 caused this to fail, any ideas @mxinden @thomaseizinger ?

The code you are referencing is mplex but the logs suggest that this happens during the QUIC measurement. Broken pipe is likely just a spurious IO error so we just need to restart this.

@mxinden
Copy link
Member

mxinden commented Sep 6, 2023

@maschad can this be included in #291? I.e. can you introduce the new js-libp2p perf version along once we have the fix?

@maschad
Copy link
Member Author

maschad commented Sep 6, 2023

@mxinden good idea.

@maschad
Copy link
Member Author

maschad commented Sep 6, 2023

Closing in favour of #299

@maschad maschad closed this Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants