Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make rust-chromium a separate implementation #302

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

thomaseizinger
Copy link
Contributor

The current caching implementation expects only a single docker container per implementation directory. This was not true for Rust v0.52 which produced two containers: A native one and one with chromium and a WASM build.

Thus, the latter never got cached and we were rebuilding it on every run. By making it a separate implementation, the cache should be picked up again.

I refrained from extending the cache implementation to handle this because I think it would get too complicated.

Resolves: #301.

@thomaseizinger
Copy link
Contributor Author

Marking this as draft until I can confirm that it actually works.

@thomaseizinger
Copy link
Contributor Author

It should work now:

We can see that the two keys are different.

@thomaseizinger thomaseizinger marked this pull request as ready for review September 13, 2023 09:40
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me! Thank you for debugging.

@thomaseizinger thomaseizinger merged commit d9a5c38 into libp2p:master Sep 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust's WASM container is not cached properly
2 participants