Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with AutoForwardDiff #27

Open
zaikunzhang opened this issue Apr 2, 2024 · 4 comments
Open

Issues with AutoForwardDiff #27

zaikunzhang opened this issue Apr 2, 2024 · 4 comments

Comments

@zaikunzhang
Copy link
Member

zaikunzhang commented Apr 2, 2024

Hi @amontoison and @emmt ,

Could you have a look at the following correlated issues?

SciML/Optimization.jl#719

soldasim/BOSS.jl#28

I do believe this is a problem with the Julia interface. Shouldn't we just ignore anything related to automatic deafferentation, since PRIMA does not use it at all?

Quoting the first issue:

The COBYLA algorithm apparently uses AD for automatic detection of linear/nonlinear constraints (despite being derivative-free). It should not error when AD is provided though.

This isn't the case, right?

Quoting the second issue:

Created an issue at Optimization.jl: SciML/Optimization.jl#719

For all the unconstrained algorithms, pass keyword autodiff = nothing to OptimizationAM and OptimizationMLE as a workaround.

COBYLA is probably just broken until this is resolved. (Unless other AD backends work. (?))

This is important for us. People believe that PRIMA.jl is broken ...

Thanks!

Zaikun

@amontoison
Copy link
Member

amontoison commented Apr 2, 2024

@zaikunzhang
The issue is upstream, they didn't interfaced correctly PRIMA.jl.
It seems that they already fixed the problem in SciML/Optimization.jl:
SciML/Optimization.jl#721

@emmt
Copy link
Collaborator

emmt commented Apr 3, 2024

No PRIMA.jl is certainly not broken (there is however the Windows issue with CUTEst) and does not use AD at all, just the values returned by the objective function. The reported issue is clearly a misuse of the method, I think that's what has been already answered.

@soldasim
Copy link

soldasim commented Apr 3, 2024

Hello, the issue SciML/Optimization.jl#719 was definitely on the side of Optimization.jl, not PRIMA.jl itself. (And it also only occurred when using PRIMA.jl via Optimization.jl.) That's why I opened the issue there.

Similarly, the AD is used for detection of lin/nonlin constraints by Optimization.jl, not COBYLA itself.

I just worded myself poorely. Sorry about that. :)

PS: Thanks for the great implementation of great algorithms! :)) PRIMA has quickly become my favorite robust derivative-free optimization library.

@zaikunzhang
Copy link
Member Author

Hi @soldasim ,

Great! Thank you for letting us know!

Best regards,
Zaikun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants