Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight selection within player options lists (captions, audio track, etc.) #6466

Closed
3 tasks done
PhilC813 opened this issue Sep 8, 2024 · 1 comment · Fixed by #6482
Closed
3 tasks done

Highlight selection within player options lists (captions, audio track, etc.) #6466

PhilC813 opened this issue Sep 8, 2024 · 1 comment · Fixed by #6482
Labels
enhancement New feature or request

Comments

@PhilC813
Copy link
Contributor

PhilC813 commented Sep 8, 2024

Describe your suggested feature

When you tap the cogwheel within the overlay during a video playback, a sheet appears with multiple options.

2024_09_08_02 02 38

The selection for each option is shown in parentheses, as expected.

Screenshot_20240908_015745

However, once you tap on one of these options, the selection is not highlighted within the list of choices, at least for many of the options.


Here are the options that do highlight the selection within their list:

  • Sleep timer
  • Quality

"Quality" option list:
2024_09_08_02 08 52


And here are those that don't:

  • Repeat Mode
  • Resize mode
  • Playback speed
  • Audio track
  • Captions

"Repeat Mode" option list:
Repeat Mode


It would be more intuitive and consistent if the selection was highlighted within the list for all available options.

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Bnyro
Copy link
Member

Bnyro commented Sep 10, 2024

Playback speed

That point is fault, the playback speed is displayed correctly at its own bottom sheet.

I've added support for that anywhere else now (captions, audio language, ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants